[release-20.0] smartconnpool: Better handling for idle expiration (#17757)

[vitess-bot]

Description

This is a backport of #17757

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[vitess-bot]

Hello! 👋

This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked.

You can find the performance comparison on the arewefastyet website.

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.44%. Comparing base (2a75a7e) to head (b034663).
Report is 1 commits behind head on release-20.0.

Files with missing lines	Patch %	Lines
go/pools/smartconnpool/timestamp.go	87.87%	4 Missing ⚠️
go/pools/smartconnpool/pool.go	95.83%	2 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-20.0   #17780      +/-   ##
================================================
+ Coverage         66.41%   66.44%   +0.03%     
================================================
  Files              1542     1543       +1     
  Lines            244190   244228      +38     
================================================
+ Hits             162176   162281     +105     
+ Misses            82014    81947      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.