Skip to content

bugfix: support subqueries inside subqueries when merging#17764

Merged
systay merged 2 commits intovitessio:mainfrom
planetscale:subq-in-subq
Feb 13, 2025
Merged

bugfix: support subqueries inside subqueries when merging#17764
systay merged 2 commits intovitessio:mainfrom
planetscale:subq-in-subq

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Feb 12, 2025

Description

Subqueries inside subqueries were not handled well if they could all be merged into a single query.

Related Issue(s)

Fixes #17775

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andres Taylor <andres@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Feb 12, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 12, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Feb 12, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.94%. Comparing base (22cf8b6) to head (d54f622).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17764      +/-   ##
==========================================
- Coverage   67.95%   67.94%   -0.02%     
==========================================
  Files        1585     1585              
  Lines      255162   255169       +7     
==========================================
- Hits       173408   173382      -26     
- Misses      81754    81787      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay added Type: Bug Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 13, 2025
@systay systay marked this pull request as ready for review February 13, 2025 05:56
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit d4e0f91 into vitessio:main Feb 13, 2025
103 checks passed
@systay systay deleted the subq-in-subq branch February 13, 2025 07:13
systay added a commit to planetscale/vitess that referenced this pull request Feb 17, 2025
…7764)

Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added a commit to planetscale/vitess that referenced this pull request Feb 17, 2025
…7764)

Signed-off-by: Andres Taylor <andres@planetscale.com>
systay added a commit to planetscale/vitess that referenced this pull request Feb 17, 2025
…7764)

Signed-off-by: Andres Taylor <andres@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong plan for merged subquery inside subquery

3 participants