bugfix: support subqueries inside subqueries when merging#17764
Merged
systay merged 2 commits intovitessio:mainfrom Feb 13, 2025
Merged
bugfix: support subqueries inside subqueries when merging#17764systay merged 2 commits intovitessio:mainfrom
systay merged 2 commits intovitessio:mainfrom
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17764 +/- ##
==========================================
- Coverage 67.95% 67.94% -0.02%
==========================================
Files 1585 1585
Lines 255162 255169 +7
==========================================
- Hits 173408 173382 -26
- Misses 81754 81787 +33 ☔ View full report in Codecov by Sentry. |
GuptaManan100
approved these changes
Feb 13, 2025
Signed-off-by: Andres Taylor <andres@planetscale.com>
harshit-gangal
approved these changes
Feb 13, 2025
systay
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 17, 2025
…7764) Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 17, 2025
…7764) Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
added a commit
to planetscale/vitess
that referenced
this pull request
Feb 17, 2025
…7764) Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Subqueries inside subqueries were not handled well if they could all be merged into a single query.
Related Issue(s)
Fixes #17775
Checklist
Deployment Notes