Skip to content

Update base images to bookworm#17539

Closed
dbussink wants to merge 1 commit intovitessio:mainfrom
planetscale:dbussink/update-to-bookworm
Closed

Update base images to bookworm#17539
dbussink wants to merge 1 commit intovitessio:mainfrom
planetscale:dbussink/update-to-bookworm

Conversation

@dbussink
Copy link
Copy Markdown
Member

@dbussink dbussink commented Jan 15, 2025

Bullseye is already in the LTS phase, so we really should upgrade to bookworm here.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink
Update base images to bookworm
d35613f 
Bullseye is already in the LTS phase, so we really should upgrade to
bookworm here.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jan 15, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 15, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 15, 2025
@frouioui frouioui mentioned this pull request Jan 15, 2025
Merged
5 tasks
L3o-pold
L3o-pold reviewed Jan 16, 2025
View reviewed changes
docker/bootstrap/Dockerfile.common
FROM --platform=linux/amd64 golang:1.23.4-bookworm

# Install Vitess build dependencies
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
Copy link
Copy Markdown
Collaborator

@L3o-pold L3o-pold Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etcd package do not longer exists in bookworm if I am not mistaken. Should be replaced with etcd-client and etcd-server

@dbussink
Copy link
Copy Markdown
Member Author

dbussink commented Jan 16, 2025

This depends on #17552 as well.

@dbussink
Copy link
Copy Markdown
Member Author

dbussink commented Jan 20, 2025

Added to #17552 since MySQL 8.0.40 is no longer published for Debian Bullseye.

@dbussink dbussink closed this Jan 20, 2025
@dbussink dbussink deleted the dbussink/update-to-bookworm branch January 20, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@L3o-pold L3o-pold L3o-pold left review comments

@deepthi deepthi Awaiting requested review from deepthi

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

Assignees

No one assigned

Labels

NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Milestone

v22.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dbussink @L3o-pold