Skip to content

[release-19.0] Fix week number for date_format evalengine function (#17432)#17454

Merged
dbussink merged 2 commits intovitessio:release-19.0from
planetscale:release-19.0-backport-evalengine-fix
Dec 30, 2024
Merged

[release-19.0] Fix week number for date_format evalengine function (#17432)#17454
dbussink merged 2 commits intovitessio:release-19.0from
planetscale:release-19.0-backport-evalengine-fix

Conversation

@dbussink
Copy link
Member

Backport #17432 to fix CI

Related Issue(s)

Fix from #17432

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@dbussink dbussink added Type: Bug Backport This is a backport Component: Evalengine changes to the evaluation engine labels Dec 30, 2024
@dbussink dbussink requested a review from deepthi as a code owner December 30, 2024 11:02
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Dec 30, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the release-19.0-backport-evalengine-fix branch from ab49463 to d2fa319 Compare December 30, 2024 11:03
@dbussink dbussink changed the title Release 19.0 backport evalengine fix [release-19.0] Fix week number for date_format evalengine function (#17432) Dec 30, 2024
@codecov
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.14%. Comparing base (e2b5c1e) to head (d74c07b).
Report is 1 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #17454      +/-   ##
================================================
+ Coverage         65.12%   65.14%   +0.01%     
================================================
  Files              1560     1560              
  Lines            238322   238316       -6     
================================================
+ Hits             155218   155255      +37     
+ Misses            83104    83061      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Manan Gupta <manan@planetscale.com>
@dbussink dbussink merged commit 765a103 into vitessio:release-19.0 Dec 30, 2024
@dbussink dbussink deleted the release-19.0-backport-evalengine-fix branch December 30, 2024 14:15
tanjinx pushed a commit to slackhq/vitess that referenced this pull request Dec 31, 2025
…itessio#17432) (vitessio#17454)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
tanjinx added a commit to slackhq/vitess that referenced this pull request Dec 31, 2025
…ons (#768)

* [release-19.0] Implement temporal comparisons (vitessio#17826) (vitessio#17852)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

* [release-19.0] Fix week number for date_format evalengine function (vitessio#17432) (vitessio#17454)

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Evalengine changes to the evaluation engine Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants