-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection pool: max idle connections implementation #17443
Open
harshit-gangal
wants to merge
5
commits into
vitessio:main
Choose a base branch
from
planetscale:max-idle-connections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+173
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Dec 27, 2024
harshit-gangal
removed
the
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
label
Dec 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17443 +/- ##
==========================================
- Coverage 67.67% 67.66% -0.01%
==========================================
Files 1583 1583
Lines 254363 254394 +31
==========================================
- Hits 172140 172137 -3
- Misses 82223 82257 +34 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
max-idle-connections
branch
from
January 6, 2025 11:59
10025af
to
ea13abf
Compare
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
…lied to the pool Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
added
Type: Feature
Component: Query Serving
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
labels
Jan 7, 2025
harshit-gangal
requested review from
systay,
shlomi-noach,
rohit-nayak-ps,
timvaillancourt and
deepthi
as code owners
January 7, 2025 16:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Query Serving
NeedsWebsiteDocsUpdate
What it says
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
Type: Feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for maximum idle connection in the pool.
The 3 pools gets it's own parameter for configuration:
queryserver-config-query-pool-max-idle-count
queryserver-config-stream-pool-max-idle-count
queryserver-config-txpool-max-idle-count
Related Issue(s)
Checklist
Deployment Notes