Improved Compatibility Around LAST_INSERT_ID - evalengine#17409
Merged
harshit-gangal merged 13 commits intovitessio:mainfrom Jan 8, 2025
Merged
Improved Compatibility Around LAST_INSERT_ID - evalengine#17409harshit-gangal merged 13 commits intovitessio:mainfrom
harshit-gangal merged 13 commits intovitessio:mainfrom
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
6fcd9e1 to
b6295b7
Compare
5 tasks
c7364f5 to
e133d2f
Compare
c270b66 to
a18dc21
Compare
Member
|
This PR should handle all the insert cases for |
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Vicent Marti <vmg@strn.cat>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
d495b01 to
e6e6742
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
approved these changes
Jan 7, 2025
| "main.unsharded" | ||
| ] | ||
| }, | ||
| "skip_e2e": true |
Member
There was a problem hiding this comment.
this should not be skipped
Collaborator
Author
There was a problem hiding this comment.
it needs to be skipped. we keep getting primary key violations if we don't skip it
harshit-gangal
approved these changes
Jan 8, 2025
Member
harshit-gangal
left a comment
There was a problem hiding this comment.
looks good overall,
Let's update website doc for compatibility and mention the limitations and new support added.
Collaborator
Author
|
Added docs vitessio/website#1913 |
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves
LAST_INSERT_ID(x)behavior to align more closely with MySQL in various scenarios.LAST_INSERT_ID(x)queries directly in vtgate, allowing “dual-only” queries without sending them downstream to MySQL.can be processed at vtgate level (aggregation across shards), rather than relying on MySQL for the final result.
Limitation
In Vitess, we do not guarantee that the last row dictates the session value. The session’s
LAST_INSERT_IDmight be derived from a different row.This PR contains commits from #17408
When merging this, please also merge the docs PR: vitessio/website#1913
Related Issue(s)
Checklist