WIP: engine.Reload(): read table sizes asynchronously#17102
Closed
shlomi-noach wants to merge 1 commit intovitessio:mainfrom
Closed
WIP: engine.Reload(): read table sizes asynchronously#17102shlomi-noach wants to merge 1 commit intovitessio:mainfrom
engine.Reload(): read table sizes asynchronously#17102shlomi-noach wants to merge 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Contributor
Author
|
this looks like will require some major refactor. #17118 is hopefully good enough for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #17101: when calling
Reload(), run a synchronous load of tables without sizes, and an asynchronous load of tables with sizes (delayed by 1 minute).Related Issue(s)
Checklist
Deployment Notes