Fix release 18 again#17069
Merged
harshit-gangal merged 2 commits intovitessio:release-18.0from Oct 28, 2024
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
harshit-gangal
force-pushed
the
fix-release-18-again
branch
from
f54cc03 to
feaa6d5
Compare
harshit-gangal
added
Type: Bug
Component: Query Serving
Type: Regression
and removed
NeedsWebsiteDocsUpdate
arthurschreiber
approved these changes
Oct 28, 2024
harshit-gangal
removed
NeedsDescriptionUpdate
harshit-gangal
requested review from
GuptaManan100,
frouioui and
harshit-gangal
as code owners
Comment on lines
-569
to
+572
| qb.ctx.SkipPredicates[jc.RHSExpr] = nil | ||
|
|
||
| _ = qb.ctx.SkipJoinPredicates(jc.Original.Expr) | ||
| return jc.Original.Expr | ||
| }) | ||
|
|
Member
There was a problem hiding this comment.
the error returned is not checked.
Should this be handled?
Member
There was a problem hiding this comment.
I think we talked about this with @systay, and handling the error leads to some changes in behaviour and various tests failures. 🤔
Member
There was a problem hiding this comment.
It was for Foreign keys but that should not happen anymore.
Member
There was a problem hiding this comment.
I am not sure about any other test failing.
Collaborator
Author
There was a problem hiding this comment.
I've added the error checking. let's see what CI thinks 🤞
harshit-gangal
approved these changes
Oct 28, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is on top of other planner bug fix PR that introduced a regression in a backport to v18.
Related Issue(s)
Checklist
Deployment Notes