feat: add metrics for atomic distributed transactions#16939
Merged
harshit-gangal merged 6 commits intovitessio:mainfrom Oct 21, 2024
Merged
feat: add metrics for atomic distributed transactions#16939harshit-gangal merged 6 commits intovitessio:mainfrom
harshit-gangal merged 6 commits intovitessio:mainfrom
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16939 +/- ##
==========================================
- Coverage 69.35% 69.34% -0.01%
==========================================
Files 1571 1571
Lines 204149 204214 +65
==========================================
+ Hits 141583 141613 +30
- Misses 62566 62601 +35 ☔ View full report in Codecov by Sentry. |
424d767 to
bb63869
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
bb63869 to
4d877f9
Compare
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ransactions Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
GuptaManan100
approved these changes
Oct 17, 2024
systay
reviewed
Oct 21, 2024
| logStats *tabletenv.LogStats | ||
| te *TxEngine | ||
| qe *QueryEngine | ||
| shardFunc func() string |
Collaborator
There was a problem hiding this comment.
mind adding a comment about what this is?
Member
Author
There was a problem hiding this comment.
I will add on a follow up PR.
systay
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds metrics to distributed transaction comit flow for tracking timings and failures.
New Metrics:
VTGate
CommitModeTimings- Timing metrics for commit (Single, Multi, TwoPC)CommitUnresolved- Counter for failure after PrepareVTTablet
UnresolvedTransaction- Gauge to track current unresolved transactions in Metadata and Resource Manager.CommitPreparedFail- Transactions that failed to commit after prepare (classified into Retryable and Non-Retryable)RedoPreparedFail- Transactions that failed to re-prepare (classified into Retryable and Non-Retryable)Related Issue(s)
Checklist
Deployment Notes