Skip to content

[release-20.0] VTAdmin: Fix serve-handler's path-to-regexp dep and add default schema refresh (#16778)#16784

Merged
frouioui merged 1 commit intorelease-20.0from
backport-16778-to-release-20.0
Sep 13, 2024
Merged

[release-20.0] VTAdmin: Fix serve-handler's path-to-regexp dep and add default schema refresh (#16778)#16784
frouioui merged 1 commit intorelease-20.0from
backport-16778-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 13, 2024

Description

This is a backport of #16778

…a refresh (#16778)

Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot vitess-bot bot requested a review from ajm188 as a code owner September 13, 2024 18:54
@vitess-bot vitess-bot bot added Backport This is a backport Component: VTAdmin VTadmin interface Type: Bug labels Sep 13, 2024
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 13, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.3 milestone Sep 13, 2024
@frouioui frouioui merged commit b058ba2 into release-20.0 Sep 13, 2024
@frouioui frouioui deleted the backport-16778-to-release-20.0 branch September 13, 2024 19:41
@codecov
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (4a0aab6) to head (138a7d5).
Report is 1 commits behind head on release-20.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16784      +/-   ##
================================================
- Coverage         68.68%   68.65%   -0.03%     
================================================
  Files              1541     1541              
  Lines            197937   197937              
================================================
- Hits             135945   135893      -52     
- Misses            61992    62044      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VTAdmin VTadmin interface Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants