Skip to content

[release-20.0] FindErrantGTIDs: superset is not an errant GTID situation (#16725)#16729

Merged
deepthi merged 1 commit intorelease-20.0from
backport-16725-to-release-20.0
Sep 9, 2024
Merged

[release-20.0] FindErrantGTIDs: superset is not an errant GTID situation (#16725)#16729
deepthi merged 1 commit intorelease-20.0from
backport-16725-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 6, 2024

Description

This is a backport of #16725

Signed-off-by: deepthi <deepthi@planetscale.com>
@vitess-bot vitess-bot bot added Backport This is a backport Component: VTOrc Vitess Orchestrator integration Type: Bug labels Sep 6, 2024
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.2 milestone Sep 6, 2024
@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (1e3d45c) to head (f412f37).
Report is 1 commits behind head on release-20.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16729      +/-   ##
================================================
+ Coverage         68.65%   68.68%   +0.02%     
================================================
  Files              1541     1541              
  Lines            197934   197937       +3     
================================================
+ Hits             135900   135950      +50     
+ Misses            62034    61987      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi merged commit e482875 into release-20.0 Sep 9, 2024
@deepthi deepthi deleted the backport-16725-to-release-20.0 branch September 9, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VTOrc Vitess Orchestrator integration Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants