Skip to content

[release-18.0] Bump upgrade tests to go1.22.7#16722

Merged
frouioui merged 1 commit intovitessio:release-18.0from
planetscale:bump-go-version-on-18
Sep 9, 2024
Merged

[release-18.0] Bump upgrade tests to go1.22.7#16722
frouioui merged 1 commit intovitessio:release-18.0from
planetscale:bump-go-version-on-18

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Sep 5, 2024

Description

This PR is a follow-up of #16721 to make sure we use the proper golang version on the upgrade tests of release-18.0.

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 5, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 5, 2024
@frouioui frouioui changed the title Bump upgrade tests to go1.22.7 [release-18.0] Bump upgrade tests to go1.22.7 Sep 5, 2024
@frouioui frouioui added Type: CI/Build Component: General Changes throughout the code base go and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 5, 2024
@github-actions github-actions bot added this to the v18.0.7 milestone Sep 5, 2024
@frouioui frouioui merged commit afb2624 into vitessio:release-18.0 Sep 9, 2024
@frouioui frouioui deleted the bump-go-version-on-18 branch September 9, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants