Skip to content

Upgrade the Golang Dependencies#16691

Merged
frouioui merged 3 commits intomainfrom
upgrade-go-deps-on-main
Sep 2, 2024
Merged

Upgrade the Golang Dependencies#16691
frouioui merged 3 commits intomainfrom
upgrade-go-deps-on-main

Conversation

@vitess-bot
Copy link
Contributor

This Pull Request updates all the Golang dependencies to their latest version using go get -u ./....

cc @vitessio/release

Signed-off-by: GitHub <noreply@github.com>
@vitess-bot vitess-bot requested a review from ajm188 as a code owner September 1, 2024 00:20
@vitess-bot vitess-bot added Component: General Changes throughout the code base go labels Sep 1, 2024
@vitess-bot vitess-bot requested a review from deepthi as a code owner September 1, 2024 00:20
@vitess-bot vitess-bot added the Type: Dependencies Dependency updates label Sep 1, 2024
@vitess-bot vitess-bot requested a review from a team September 1, 2024 00:20
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 1, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 1, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 1, 2024
@codecov
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (977b9a3) to head (f9fed87).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16691      +/-   ##
==========================================
+ Coverage   68.95%   69.00%   +0.05%     
==========================================
  Files        1565     1565              
  Lines      201530   201880     +350     
==========================================
+ Hits       138957   139315     +358     
+ Misses      62573    62565       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@systay systay removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 2, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay requested a review from notfelineit as a code owner September 2, 2024 14:59
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay force-pushed the upgrade-go-deps-on-main branch from 3ae8dcf to f9fed87 Compare September 2, 2024 15:03
@frouioui frouioui merged commit c579c3b into main Sep 2, 2024
@frouioui frouioui deleted the upgrade-go-deps-on-main branch September 2, 2024 20:29
@dbussink dbussink mentioned this pull request Sep 3, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base go Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants