v20 backport: Throttler/vreplication: fix app name used by VPlayer (#16578)#16579
Merged
shlomi-noach merged 1 commit intovitessio:release-20.0from Aug 12, 2024
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
rohit-nayak-ps
approved these changes
Aug 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16579 +/- ##
=============================================
Coverage 68.67% 68.68%
=============================================
Files 1541 1541
Lines 197870 197870
=============================================
+ Hits 135888 135900 +12
+ Misses 61982 61970 -12 ☔ View full report in Codecov by Sentry. |
systay
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #16578 to 20.0
Description
VPlayerwas incorrectly identifying itself to the throttler asvcopier. As result, runningApplyThrottlerConfig --throttle-app=vplayermade no effect on VPlayer. This PR fixes the problem.Related Issue(s)
Context: #16575 (this PR does not fix this issue, just related)
Backports
This is a bug. Backporting to 20, 19, 18 where this issue is relevant.
Checklist
Deployment Notes