VReplication: Return lock error everywhere that LockName fails

[mattlord]

Description

This is a follow-up to #16260.

Somehow, in 3 places, the return was missed when the LockName call failed. That is corrected here, along with unit test additions to cover this scenario.

I also took the opportunity to unify the error handling and error messages.

Related Issue(s)

• Follow-up to: VReplication: use new topo named locks and TTL override for workflow coordination #16260
• Fixes: Bug Report: Errors returned by LockName are not being handled properly in vtctl workflow #16559

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 18.75000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (8f0d2d4) to head (ba9f7b4).

Files	Patch %	Lines
go/vt/vtctl/workflow/server.go	7.14%	26 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16560      +/-   ##
==========================================
+ Coverage   68.76%   68.84%   +0.08%     
==========================================
  Files        1556     1556              
  Lines      199807   199807              
==========================================
+ Hits       137391   137561     +170     
+ Misses      62416    62246     -170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.