[release-20.0] Upgrade the Golang version to go1.22.6#16546
Merged
frouioui merged 8 commits intorelease-20.0from Aug 20, 2024
Merged
[release-20.0] Upgrade the Golang version to go1.22.6#16546frouioui merged 8 commits intorelease-20.0from
go1.22.6#16546frouioui merged 8 commits intorelease-20.0from
Conversation
Signed-off-by: GitHub <noreply@github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Contributor
|
Hello! 👋 This Pull Request is now handled by arewefastyet. The current HEAD and future commits will be benchmarked. You can find the performance comparison on the arewefastyet website. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16546 +/- ##
================================================
+ Coverage 68.65% 68.71% +0.05%
================================================
Files 1541 1541
Lines 197864 199269 +1405
================================================
+ Hits 135850 136934 +1084
- Misses 62014 62335 +321 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
38a0b91 to
d452817
Compare
frouioui
reviewed
Aug 14, 2024
Comment on lines
+19
to
+20
| apt-get update -y && apt-get install -y percona-release && \ | ||
| percona-release enable-only tools && apt-get update -y && \ |
Member
There was a problem hiding this comment.
Fix required to install percona.
Collaborator
There was a problem hiding this comment.
v20 does not support 5.7 any more, does it? Can't we delete this and the percona57 version?
frouioui
approved these changes
Aug 14, 2024
This was referenced Aug 14, 2024
deepthi
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request bumps the Golang version to
go1.22.6and the bootstrap version to32.2.There are a few manual steps remaining:
./.github/workflows/*.ymlfiles with the newer Golang version, the bot cannot handle that due to permissions.go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.22.6cc @vitessio/release