Fix panic in user defined aggregation functions planning#16398
Merged
systay merged 1 commit intovitessio:mainfrom Jul 16, 2024
Merged
Fix panic in user defined aggregation functions planning#16398systay merged 1 commit intovitessio:mainfrom
systay merged 1 commit intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16398 +/- ##
==========================================
- Coverage 68.68% 68.67% -0.01%
==========================================
Files 1548 1548
Lines 199063 199087 +24
==========================================
+ Hits 136721 136727 +6
- Misses 62342 62360 +18 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Jul 16, 2024
This was referenced Jul 16, 2024
This was referenced Jul 16, 2024
Merged
GuptaManan100
added a commit
that referenced
this pull request
Jul 16, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the panic found in #16397.
On investigation it was found that this panic was introduced in the changes in #16049. This PR fixes the panic and also adds test cases to verify we are able to plan udf queries properly and fail in case we are unable to push them down to MySQL.
Related Issue(s)
Checklist
Deployment Notes