Skip to content

[release-20.0] CI: Fix for xtrabackup install failures (#16329)#16333

Merged
mattlord merged 1 commit intorelease-20.0from
backport-16329-to-release-20.0
Jul 3, 2024
Merged

[release-20.0] CI: Fix for xtrabackup install failures (#16329)#16333
mattlord merged 1 commit intorelease-20.0from
backport-16329-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 3, 2024

Description

This is a backport of #16329

Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 3, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v20.0.1 milestone Jul 3, 2024
@codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (6096e1f) to head (ba1fa86).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16333      +/-   ##
================================================
- Coverage         68.65%   68.64%   -0.01%     
================================================
  Files              1541     1541              
  Lines            197830   197830              
================================================
- Hits             135821   135808      -13     
- Misses            62009    62022      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord merged commit 3d14b31 into release-20.0 Jul 3, 2024
@mattlord mattlord deleted the backport-16329-to-release-20.0 branch July 3, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants