[release-20.0] Fix Incorrect Optimization with LIMIT and GROUP BY (#16263)#16268
Merged
systay merged 6 commits intorelease-20.0from Jun 27, 2024
Merged
[release-20.0] Fix Incorrect Optimization with LIMIT and GROUP BY (#16263)#16268systay merged 6 commits intorelease-20.0from
systay merged 6 commits intorelease-20.0from
Conversation
Signed-off-by: Andres Taylor <andres@planetscale.com>
Contributor
Author
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-20.0 #16268 +/- ##
=============================================
Coverage 68.60% 68.60%
=============================================
Files 1541 1541
Lines 197812 197814 +2
=============================================
+ Hits 135702 135718 +16
+ Misses 62110 62096 -14 ☔ View full report in Codecov by Sentry. |
frouioui
reviewed
Jun 26, 2024
go/test/endtoend/vtgate/queries/aggregation/aggregation_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
frouioui
approved these changes
Jun 26, 2024
frouioui
reviewed
Jun 26, 2024
go/test/endtoend/vtgate/queries/aggregation/aggregation_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
d914e7f to
d05f982
Compare
Member
|
I forced push the same commit again on this PR, for some reason the CI workflows were blocked in |
frouioui
reviewed
Jun 26, 2024
Dismissing as the end-to-end test seems to be wrong.
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
systay
approved these changes
Jun 27, 2024
systay
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #16263