CI: testing self referencing tables in foreign key stress tests#16216
Merged
shlomi-noach merged 3 commits intovitessio:mainfrom Jun 19, 2024
Merged
CI: testing self referencing tables in foreign key stress tests#16216shlomi-noach merged 3 commits intovitessio:mainfrom
shlomi-noach merged 3 commits intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16216 +/- ##
==========================================
+ Coverage 68.55% 68.56% +0.01%
==========================================
Files 1544 1544
Lines 197895 197895
==========================================
+ Hits 135658 135678 +20
+ Misses 62237 62217 -20 ☔ View full report in Codecov by Sentry. |
frouioui
approved these changes
Jun 18, 2024
dbussink
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a self referencing table to the foreign key stress tests. The self referencing table goes through mostly the same tests as other tables, but note:
ON DELETE CASCADEnorON UPDATE CASCADEas these create a multitude of unexpected scenarios where collected metrics cannot be validated.Related Issue(s)
Checklist
Deployment Notes