Skip to content

[release-20.0] Online DDL shadow table: rename referenced table name in self referencing FK (#16205)#16209

Merged
shlomi-noach merged 1 commit intorelease-20.0from
backport-16205-to-release-20.0
Jun 17, 2024
Merged

[release-20.0] Online DDL shadow table: rename referenced table name in self referencing FK (#16205)#16209
shlomi-noach merged 1 commit intorelease-20.0from
backport-16205-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 17, 2024

Description

This is a backport of #16205

…cing FK (#16205)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added the Backport This is a backport label Jun 17, 2024
@vitess-bot vitess-bot bot requested a review from shlomi-noach as a code owner June 17, 2024 07:50
@vitess-bot vitess-bot bot added Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug labels Jun 17, 2024
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach shlomi-noach requested a review from a team June 17, 2024 08:03
@github-actions github-actions bot added this to the v20.0.0 milestone Jun 17, 2024
@shlomi-noach shlomi-noach merged commit 6c591bd into release-20.0 Jun 17, 2024
@shlomi-noach shlomi-noach deleted the backport-16205-to-release-20.0 branch June 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant