Skip to content

[release-18.0] VDiff CLI: Fix VDiff show bug (#16177)#16197

Merged
frouioui merged 1 commit intorelease-18.0from
backport-16177-to-release-18.0
Jun 16, 2024
Merged

[release-18.0] VDiff CLI: Fix VDiff show bug (#16177)#16197
frouioui merged 1 commit intorelease-18.0from
backport-16177-to-release-18.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 15, 2024

Description

This is a backport of #16177

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner June 15, 2024 03:47
@vitess-bot vitess-bot bot added the Type: Bug label Jun 15, 2024
@vitess-bot vitess-bot bot requested a review from rohit-nayak-ps as a code owner June 15, 2024 03:47
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v18.0.6 milestone Jun 15, 2024
@frouioui frouioui merged commit 6e1a252 into release-18.0 Jun 16, 2024
@frouioui frouioui deleted the backport-16177-to-release-18.0 branch June 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants