Skip to content

VDiff CLI: Fix VDiff show bug #16177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohit-nayak-ps merged 1 commit into from
Jun 15, 2024
Merged

VDiff CLI: Fix VDiff show bug #16177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,6 @@ func getStructFieldNames(s any) []string {
}

func buildListings(listings []*listing) string {
var values []string
var lines [][]string
var result string

Expand All @@ -474,6 +473,7 @@ func buildListings(listings []*listing) string {
// The header is the first row.
lines = append(lines, fields)
for _, listing := range listings {
var values []string
v := reflect.ValueOf(*listing)
for _, field := range fields {
values = append(values, v.FieldByName(field).String())
Expand Down