CI Bug: Rename shard name back to match existing workflow file for vreplication_migrate_vdiff2_convert_tz#16148
Merged
GuptaManan100 merged 3 commits intovitessio:mainfrom Jun 13, 2024
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
dbussink
approved these changes
Jun 13, 2024
GuptaManan100
approved these changes
Jun 13, 2024
vitess-bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
…eplication_migrate_vdiff2_convert_tz (#16148) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes two changes:
The shard name
vreplication_migrate_vdiff2_convert_tzwas changed in PR VReplication: Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient #15579 but the workflow file was not renamed. Hence the related tests are no longer running in CI. This PR changes it back, so we can continue to use the same workflow name to avoid having to update the list of Required actions ...Cluster 22 was no longer necessary after Delete all legacy sharding related code #10278. Deleted that shard and removed the workflow from the Required set in the GitHub Repo Settings.
Related Issue(s)
#15579
#10278
Checklist
Deployment Notes