[release-20.0] refactor: cleaner cloning API (#16079)#16135
Closed
harshit-gangal wants to merge 1 commit intovitessio:release-20.0from
Closed
[release-20.0] refactor: cleaner cloning API (#16079)#16135harshit-gangal wants to merge 1 commit intovitessio:release-20.0from
harshit-gangal wants to merge 1 commit intovitessio:release-20.0from
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
ea28bf1 to
0758f6e
Compare
deepthi
approved these changes
Jun 12, 2024
Member
|
Although the refactor does not seem risky, let's not backport this to 20.0. It is also not needed for the subquery fix #16049 on release branches. Closing this for now, feel free to re-open if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #16079
Needed to backport the Regression fix #16049
Related Issue(s)
Checklist
Deployment Notes