Skip to content

[release-20.0] Update braces package (#16115)#16120

Merged
notfelineit merged 1 commit intorelease-20.0from
backport-16115-to-release-20.0
Jun 12, 2024
Merged

[release-20.0] Update braces package (#16115)#16120
notfelineit merged 1 commit intorelease-20.0from
backport-16115-to-release-20.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jun 12, 2024

Description

This is a backport of #16115

Signed-off-by: Frances Thai <notfelineit@gmail.com>
@vitess-bot vitess-bot bot requested a review from ajm188 as a code owner June 12, 2024 01:13
@vitess-bot vitess-bot bot added Backport This is a backport Component: VTAdmin VTadmin interface labels Jun 12, 2024
@vitess-bot vitess-bot bot requested a review from notfelineit as a code owner June 12, 2024 01:13
@vitess-bot vitess-bot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code Release Blocker: release-20.0 This item blocks the release on branch release-20.0 Type: Dependencies Dependency updates labels Jun 12, 2024
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jun 12, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@frouioui frouioui removed the Release Blocker: release-20.0 This item blocks the release on branch release-20.0 label Jun 12, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Jun 12, 2024
@codecov
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (b16adf7) to head (2a71686).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #16120      +/-   ##
================================================
+ Coverage         68.20%   68.22%   +0.01%     
================================================
  Files              1541     1541              
  Lines            197339   197339              
================================================
+ Hits             134602   134640      +38     
+ Misses            62737    62699      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notfelineit notfelineit merged commit f683028 into release-20.0 Jun 12, 2024
@notfelineit notfelineit deleted the backport-16115-to-release-20.0 branch June 12, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: VTAdmin VTadmin interface dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code Type: Dependencies Dependency updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants