Fix Data race in tests introduced in #15934#15993
Merged
GuptaManan100 merged 1 commit intovitessio:mainfrom May 22, 2024
Merged
Fix Data race in tests introduced in #15934#15993GuptaManan100 merged 1 commit intovitessio:mainfrom
GuptaManan100 merged 1 commit intovitessio:mainfrom
Conversation
… parallely Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15993 +/- ##
=======================================
Coverage 68.47% 68.48%
=======================================
Files 1562 1562
Lines 197083 197080 -3
=======================================
Hits 134962 134962
+ Misses 62121 62118 -3 ☔ View full report in Codecov by Sentry. |
mattlord
approved these changes
May 22, 2024
shlomi-noach
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a data race introduced in #15934. The test in question is changing the
topo.RemoteOperationTimeout. Since that value is used while running ERS and PRS, we cannot run that test in parallel with anyother test running a reparent operation. This PR fixes this by removign the test from running parallely with other tests.Related Issue(s)
Fixes a race introduced in #15934 which was caught in the tests in #15991 (comment)
Checklist
Deployment Notes