Remove legacy EmergencyReparentShard stats#15941
Merged
timvaillancourt merged 2 commits intovitessio:mainfrom May 29, 2024
Merged
Remove legacy EmergencyReparentShard stats#15941timvaillancourt merged 2 commits intovitessio:mainfrom
EmergencyReparentShard stats#15941timvaillancourt merged 2 commits intovitessio:mainfrom
Conversation
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
EmergencyReparentShard stats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15941 +/- ##
==========================================
+ Coverage 68.40% 68.41% +0.01%
==========================================
Files 1556 1562 +6
Lines 195121 197053 +1932
==========================================
+ Hits 133479 134821 +1342
- Misses 61642 62232 +590 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes legacy ERS stats that were deprecated by a PR I wrote in Vitess 18.0. Replacement metrics with labels were added in the same release
Related Issue(s)
#13723
Checklist
Deployment Notes