Skip to content

Remove legacy EmergencyReparentShard stats#15941

Merged
timvaillancourt merged 2 commits intovitessio:mainfrom
timvaillancourt:deprecate-legacy-ers-stats
May 29, 2024
Merged

Remove legacy EmergencyReparentShard stats#15941
timvaillancourt merged 2 commits intovitessio:mainfrom
timvaillancourt:deprecate-legacy-ers-stats

Conversation

@timvaillancourt
Copy link
Copy Markdown
Contributor

Description

This PR removes legacy ERS stats that were deprecated by a PR I wrote in Vitess 18.0. Replacement metrics with labels were added in the same release

Related Issue(s)

#13723

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented May 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 14, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 14, 2024
@timvaillancourt timvaillancourt added Type: Internal Cleanup Component: Observability Pull requests that touch tracing/metrics/monitoring Component: VTOrc Vitess Orchestrator integration Component: vtctl and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 14, 2024
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
@timvaillancourt timvaillancourt changed the title Remove legacy ERS stats Remove legacy EmergencyReparentShard stats May 14, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.41%. Comparing base (f118ba2) to head (98dc9b8).
Report is 93 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15941      +/-   ##
==========================================
+ Coverage   68.40%   68.41%   +0.01%     
==========================================
  Files        1556     1562       +6     
  Lines      195121   197053    +1932     
==========================================
+ Hits       133479   134821    +1342     
- Misses      61642    62232     +590     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi removed the NeedsIssue A linked issue is missing for this Pull Request label May 15, 2024
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timvaillancourt timvaillancourt merged commit 0a86449 into vitessio:main May 29, 2024
@timvaillancourt timvaillancourt deleted the deprecate-legacy-ers-stats branch May 29, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Observability Pull requests that touch tracing/metrics/monitoring Component: vtctl Component: VTOrc Vitess Orchestrator integration Type: Internal Cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants