Use replica queries when available#15808
Merged
dbussink merged 3 commits intovitessio:mainfrom Apr 30, 2024
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Member
Author
|
Not all end-to-end tests here have been updated yet either, that's still pending to change to use the new syntax when available as well. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15808 +/- ##
==========================================
- Coverage 68.41% 68.39% -0.03%
==========================================
Files 1558 1558
Lines 196353 196547 +194
==========================================
+ Hits 134337 134422 +85
- Misses 62016 62125 +109 ☔ View full report in Codecov by Sentry. |
0449d9b to
e7a61bb
Compare
b4579a8 to
21ac30d
Compare
This switches things over to use the replica syntax when available instead of the deprecated style. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
a5aca74 to
dffc19e
Compare
Contributor
shlomi-noach
left a comment
There was a problem hiding this comment.
See inline comments
shlomi-noach
approved these changes
Apr 30, 2024
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
mattlord
approved these changes
Apr 30, 2024
Member
mattlord
left a comment
There was a problem hiding this comment.
LGTM! I only had minor nits/comments/suggestions.
Thank you for doing this!
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches things over to use the replica syntax when available instead of the deprecated style.
Related Issue(s)
Part of #9515. The new naming is not available for all of MySQL 8.0, so we have to carry the legacy still but we can use the new syntax moving forward where possible.
Checklist