VReplication: Get workflowFlavorVtctl endtoend testing working properly again

[mattlord]

Description

After #15579 the tests that used functions in the resharding_workflows_v2_test file (primarily tstWorkflowExec()) and supported two client flavors — vtctl[client] and vtctld[client], doing both or choosing one randomly — were really using vtctldclient in both cases.

And when the flavor was vtctl[client] — both before AND after #15579 — some of the tests failed every time as they did not properly set the currentWorkflowType to MoveTables so the command did a Reshard instead as that's the default. For example, I noticed that the TestFKWorkflow test (which is executed in the vreplication_cellalias workflow) failed every time that the flavor was vtctl (the flavor being chosen randomly in that test). This was papered over by our auto retry and the fact that these workflows completed pretty quickly. You can see that test and workflow passing in this PR with the flavor being vtctl and vtctld here (run 11 times in a row): https://github.com/vitessio/vitess/actions/runs/8546382449/job/23416629462?pr=15636

This PR corrects both issues so that these tests are properly testing both flavors as expected.

I wanted to backport this to back to v18 as that's where #15579 was backported to, and these are ONLY test/CI changes.

Related Issue(s)

• Follow-up to: VReplication: Fix vtctldclient SwitchReads related bugs and move the TestBasicV2Workflows e2e test to vtctldclient #15579

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (0e2f175) to head (7af9b8b).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15636   +/-   ##
=======================================
  Coverage   68.13%   68.13%           
=======================================
  Files        1556     1556           
  Lines      194984   194984           
=======================================
+ Hits       132849   132856    +7     
+ Misses      62135    62128    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

This is a copy of what tstWorkflowExec() was prior to #15579