WIP: TabletManagerClient real pool dialer#15541
Closed
shlomi-noach wants to merge 3 commits intovitessio:mainfrom
Closed
WIP: TabletManagerClient real pool dialer#15541shlomi-noach wants to merge 3 commits intovitessio:mainfrom
TabletManagerClient real pool dialer#15541shlomi-noach wants to merge 3 commits intovitessio:mainfrom
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…t shared. A real pool Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15541 +/- ##
==========================================
+ Coverage 65.69% 65.73% +0.04%
==========================================
Files 1564 1560 -4
Lines 194588 194631 +43
==========================================
+ Hits 127832 127943 +111
+ Misses 66756 66688 -68 ☔ View full report in Codecov by Sentry. |
This was referenced Mar 24, 2024
Closed
Contributor
Author
|
This work is postponed to a later stage. Meanwhile #15562 should fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An alternative to #15520, using same tests, but with different solution.
The
TabletManagerClientpool dialer is not a real pool. It holdsnclients, and shares them arbitrarily among potentially unlimited users. This means a single client (connection) can be held concurrently by many users. Not one user has the ownership toClose()a client on error, because other users could be using that connection at that same time.,This PR addresses specifically
CheckThrottlerandFullStatusfunctions, which are invoked mroe frequently than others, and creates a new, actual pool implementation. We don't want to impact otherwise existing logic forExecute*Fetch*functions, which are also users ofdialPool. Hence we create a 2nd pool mechanism, to be used specifically by the aforementioned two functions.Related Issue(s)
poolDialer#15563Checklist
Deployment Notes