VTOrc optimize TMC usage#15356
Merged
GuptaManan100 merged 2 commits intovitessio:mainfrom Feb 27, 2024
Merged
Conversation
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15356 +/- ##
==========================================
- Coverage 67.41% 65.42% -2.00%
==========================================
Files 1560 1561 +1
Lines 192752 193529 +777
==========================================
- Hits 129952 126615 -3337
- Misses 62800 66914 +4114 ☔ View full report in Codecov by Sentry. |
deepthi
approved these changes
Feb 26, 2024
mattlord
approved these changes
Feb 26, 2024
GuptaManan100
added a commit
to planetscale/vitess
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Manan Gupta <manan@planetscale.com>
deepthi
pushed a commit
that referenced
this pull request
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the feature requested in #15355.
Similar changes to the
CheckThrottlerRPC had been made in #14979. This PR replicates them forFullStatusRPC. While working on this, a few more refactoring changes have been made to make the code more uniform.Related Issue(s)
Checklist
Deployment Notes