Skip to content

[release-19.0] vtexplain: Ensure memory topo is set up for throttler (#15279)#15285

Merged
frouioui merged 1 commit intorelease-19.0from
backport-15279-to-release-19.0
Feb 19, 2024
Merged

[release-19.0] vtexplain: Ensure memory topo is set up for throttler (#15279)#15285
frouioui merged 1 commit intorelease-19.0from
backport-15279-to-release-19.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Feb 19, 2024

Description

This is a backport of #15279

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot vitess-bot bot added the Backport This is a backport label Feb 19, 2024
@vitess-bot vitess-bot bot requested a review from harshit-gangal as a code owner February 19, 2024 14:19
@vitess-bot vitess-bot bot added Component: vtexplain changes made to vtexplain code Type: Bug labels Feb 19, 2024
@vitess-bot vitess-bot bot requested a review from dbussink February 19, 2024 14:19
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Feb 19, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.0 milestone Feb 19, 2024
@codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (b352323) 67.29% compared to head (5acfd37) 67.32%.
Report is 1 commits behind head on release-19.0.

Files Patch % Lines
go/cmd/vtexplain/cli/vtexplain.go 0.00% 3 Missing ⚠️
go/vt/vtexplain/vtexplain_vtgate.go 90.00% 3 Missing ⚠️
go/vt/vttablet/tabletserver/throttle/throttler.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15285      +/-   ##
================================================
+ Coverage         67.29%   67.32%   +0.03%     
================================================
  Files              1558     1558              
  Lines            192072   192095      +23     
================================================
+ Hits             129261   129337      +76     
+ Misses            62811    62758      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit 2f6ea24 into release-19.0 Feb 19, 2024
@frouioui frouioui deleted the backport-15279-to-release-19.0 branch February 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: vtexplain changes made to vtexplain code Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants