[release-19.0] Avoid rewriting unsharded queries and split semantic analysis in two (#15217)#15230
Merged
dbussink merged 1 commit intorelease-19.0from Feb 15, 2024
Merged
Conversation
Contributor
Author
|
Hello @frouioui, there are conflicts in this backport. Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually. Make sure you replace |
Contributor
Author
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
ee34039 to
123ccbc
Compare
frouioui
approved these changes
Feb 14, 2024
…15217) Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
123ccbc to
5ca9229
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-19.0 #15230 +/- ##
================================================
+ Coverage 67.27% 67.29% +0.01%
================================================
Files 1558 1558
Lines 191948 192044 +96
================================================
+ Hits 129136 129227 +91
- Misses 62812 62817 +5 ☔ View full report in Codecov by Sentry. |
dbussink
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #15217