Skip to content

Revert unwanted logging change to vttestserver#15148

Merged
vmg merged 3 commits intovitessio:mainfrom
planetscale:revert-unwanted-change-to-logging
Feb 6, 2024
Merged

Revert unwanted logging change to vttestserver#15148
vmg merged 3 commits intovitessio:mainfrom
planetscale:revert-unwanted-change-to-logging

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Feb 6, 2024 •
edited
Loading

Description

This PR partially reverts a recent change to logging in vttestserver which was made in #14383.

For normal build (go build) logging will be enabled by default, however, for tests logging will be enabled only if the -v flag is passed to go test.

Backporting this to both release-18.0 and release-19.0 as the issue is observed on both branches as described in #15119.

Related Issue(s)

Fixes #15119

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@frouioui
Revert unwanted change on logging for vttestserver
3941978 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui requested a review from deepthi as a code owner February 6, 2024 15:34
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 6, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 6, 2024
@frouioui frouioui added Backport to: release-18.0 Type: Bug Component: vttestserver and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 6, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 6, 2024
@frouioui frouioui requested review from ajm188, mattlord and vmg February 6, 2024 15:35
ajm188
ajm188 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one take-it-or-leave-it suggestion, I'm ambivalent :)

frouioui and others added 2 commits February 6, 2024 09:50
@frouioui @ajm188
Update go/vt/vttest/vtprocess.go
34406a8 
Co-authored-by: Andrew Mason <amason@hey.com>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
@frouioui
add missing import
e9a13f6 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vmg vmg merged commit c189cf4 into vitessio:main Feb 6, 2024
@vmg vmg deleted the revert-unwanted-change-to-logging branch February 6, 2024 16:56
vitess-bot pushed a commit that referenced this pull request Feb 6, 2024
@vitess-bot @ajm188
Revert unwanted logging change to vttestserver (#15148)
e94028b 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
@vitess-bot vitess-bot bot mentioned this pull request Feb 6, 2024
Merged
vitess-bot pushed a commit that referenced this pull request Feb 6, 2024
@vitess-bot @ajm188
Revert unwanted logging change to vttestserver (#15148)
51a5806 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
@vitess-bot vitess-bot bot mentioned this pull request Feb 6, 2024
Merged
frouioui pushed a commit that referenced this pull request Feb 6, 2024
@vitess-bot @ajm188
[release-18.0] Revert unwanted logging change to vttestserver (#15148…
209a74b 
…) (#15149)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
frouioui added a commit to planetscale/vitess that referenced this pull request Feb 6, 2024
@frouioui @ajm188
Revert unwanted logging change to vttestserver (vitessio#15148)
7fce5f7 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
frouioui pushed a commit that referenced this pull request Feb 7, 2024
@vitess-bot @ajm188
[release-19.0] Revert unwanted logging change to vttestserver (#15148…
75416b7 
…) (#15150)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Co-authored-by: Andrew Mason <amason@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmg vmg vmg approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi

+1 more reviewer

@ajm188 ajm188 ajm188 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: vttestserver Type: Bug

Projects

None yet

Milestone

v20.0.0

Development

Successfully merging this pull request may close these issues.

Bug Report: vttestserver shows no vtcombo logs on stdout/stderr

4 participants

@frouioui @vmg @mattlord @ajm188