Skip to content

[release-18.0] Update MySQL apt package and GPG signature (#14785)#14792

Merged
mattlord merged 1 commit intorelease-18.0from
backport-14785-to-release-18.0
Dec 15, 2023
Merged

[release-18.0] Update MySQL apt package and GPG signature (#14785)#14792
mattlord merged 1 commit intorelease-18.0from
backport-14785-to-release-18.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 15, 2023

Description

This is a backport of #14785

@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Merge Conflict Skip CI Skip CI actions from running Type: CI/Build labels Dec 15, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 15, 2023

Hello @mattlord, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 14792 -R vitessio/vitess
git reset --hard origin/release-18.0
git cherry-pick -m 1 c2ff09f2a9d00b2aaa67db9d3aa169d36303a013

@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 15, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v18.0.2 milestone Dec 15, 2023
@mattlord mattlord force-pushed the backport-14785-to-release-18.0 branch from 3afca32 to 252d283 Compare December 15, 2023 15:18
@mattlord mattlord removed Skip CI Skip CI actions from running Merge Conflict labels Dec 15, 2023
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the backport-14785-to-release-18.0 branch from 252d283 to b8d58d3 Compare December 15, 2023 15:19
@mattlord mattlord marked this pull request as ready for review December 15, 2023 15:19
@mattlord mattlord merged commit 3d75c2c into release-18.0 Dec 15, 2023
@mattlord mattlord deleted the backport-14785-to-release-18.0 branch December 15, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants