cleanup deprecated flag types in tabletenv#14733
Merged
ajm188 merged 6 commits intovitessio:mainfrom Dec 14, 2023
Merged
Conversation
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
added 5 commits
December 8, 2023 10:48
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
deepthi
approved these changes
Dec 11, 2023
Collaborator
deepthi
left a comment
There was a problem hiding this comment.
Flag docs will be regenerated, right?
I added the website docs label more to kick CI than anything else, the check was pending. But it also felt appropriate.
Contributor
Author
seems like the bot hasn't been auto-generating the docs, so i'll look into why today. i'll do it manually for now |
dbussink
approved these changes
Dec 14, 2023
shlomi-noach
approved these changes
Dec 14, 2023
Contributor
shlomi-noach
left a comment
There was a problem hiding this comment.
Nice! Thanks for the hard work.
This was referenced Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This cleans up the deprecated float/duration interop flags in tabletenv to make them easier to viperize later.
Related Issue(s)
Checklist
Deployment Notes