Skip to content

[release-15.0] Fix anonymous paths in cobra code-gen (#14185)#14235

Merged
frouioui merged 1 commit intorelease-15.0from
backport-14185-to-release-15.0
Oct 12, 2023
Merged

[release-15.0] Fix anonymous paths in cobra code-gen (#14185)#14235
frouioui merged 1 commit intorelease-15.0from
backport-14185-to-release-15.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Oct 10, 2023

Description

This is a backport of #14185

@vitess-bot vitess-bot bot requested a review from ajm188 as a code owner October 10, 2023 23:37
@vitess-bot vitess-bot bot added Backport This is a backport Component: CLI labels Oct 10, 2023
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner October 10, 2023 23:37
@vitess-bot vitess-bot bot added the Type: Bug label Oct 10, 2023
@vitess-bot vitess-bot bot requested a review from frouioui October 10, 2023 23:37
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Oct 10, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v15.0.6 milestone Oct 10, 2023
@frouioui frouioui merged commit 57a7158 into release-15.0 Oct 12, 2023
@frouioui frouioui deleted the backport-14185-to-release-15.0 branch October 12, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants