Mark non-unique lookup vindex as backfill to ignore vindex selection

[aparajon]

Description

As a follow-up to #13505, this PR enables non-unique lookups to support the isBackfilling interface. This will prevent non-unique lookups from vindex selection during a backfill (i.e. when write_only is set to true).

Related Issue(s)

• Bug Report: write_only vindexes are incorrectly prioritized #13486

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on the CI
• Documentation was added or is not required

Deployment Notes

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[harshit-gangal]

add this to ConsistentLookup as well.

[aparajon]

Added in 7361fe245816db696c12da9306da125539aacffa, I think using *clCommon should take care of that.

[harshit-gangal]

Thank you for your contribution. I updated the title to suit the changes.

[harshit-gangal]

the plan_test is failing

  "Query": "select * from customer where name = 'x'" => "select * from customer where `name` = 'x'",

can you update the expected query so that the test can be 🟢

[aparajon]

the plan_test is failing

  "Query": "select * from customer where name = 'x'" => "select * from customer where `name` = 'x'",

can you update the expected query so that the test can be 🟢

Done, would you mind running the tests again?

[frouioui]

Done, would you mind running the tests again?

Done, they are re-triggered.

[GuptaManan100]

Ugh, the CI failed on 2023-11-23T21:17:31.6621372Z === RUN TestFuzzRewriting/((n0_xor_n0)_and_(n1_xor_n2)_or_(n0_or_n2)_xor_(n0_xor_n1))_xor_n0 2023-11-23T21:17:31.6621491Z panic: test timed out after 10m0s. This has been fixed in main. Would you mind merging main so that the tests can go green

[aparajon]

Ugh, the CI failed on 2023-11-23T21:17:31.6621372Z === RUN TestFuzzRewriting/((n0_xor_n0)_and_(n1_xor_n2)_or_(n0_or_n2)_xor_(n0_xor_n1))_xor_n0 2023-11-23T21:17:31.6621491Z panic: test timed out after 10m0s. This has been fixed in main. Would you mind merging main so that the tests can go green

Sure, just did. Is there a way to enable CI to run after a new git change is made in this PR? Don't want to keep bothering you all 😄

[github-actions]

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

• Push additional commits to the associated branch.
• Remove the stale label.
• Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

[systay]

hi @aparajon

not sure why CI is not starting. if you merge main again and push, it should start, and then we can merge your contribution.

sorry for the hassle

[aparajon]

hi @aparajon

not sure why CI is not starting. if you merge main again and push, it should start, and then we can merge your contribution.

sorry for the hassle

Thanks @systay, I wonder if it's due to the way I've been syncing updates with main. I've been doing:

1. Sync my fork with main through the UI
2. Run git pull --rebase in my fork
3. Run git push origin -f add-backfill-support-for-nonunique-lookups in my fork

Just ran this again.