Skip to content

[release-15.0] docker: add dedicated vtorc container (#14126)#14145

Merged
frouioui merged 1 commit intorelease-15.0from
backport-14126-to-release-15.0
Oct 2, 2023
Merged

[release-15.0] docker: add dedicated vtorc container (#14126)#14145
frouioui merged 1 commit intorelease-15.0from
backport-14126-to-release-15.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 29, 2023

Description

This is a backport of #14126

@vitess-bot vitess-bot bot added the Backport This is a backport label Sep 29, 2023
@vitess-bot vitess-bot bot requested a review from GuptaManan100 as a code owner September 29, 2023 22:47
@vitess-bot vitess-bot bot requested a review from frouioui as a code owner September 29, 2023 22:47
@vitess-bot vitess-bot bot added Component: VTOrc Vitess Orchestrator integration Type: CI/Build labels Sep 29, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 29, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 29, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 29, 2023
@github-actions github-actions bot added this to the v15.0.5 milestone Sep 29, 2023
@frouioui frouioui merged commit 92e7f99 into release-15.0 Oct 2, 2023
@frouioui frouioui deleted the backport-14126-to-release-15.0 branch October 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI Component: VTOrc Vitess Orchestrator integration Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants