Skip to content

[release-15.0] bugfix: change column name and type to json (#14093)#14115

Merged
mattlord merged 3 commits intorelease-15.0from
backport-14093-to-release-15.0
Sep 29, 2023
Merged

[release-15.0] bugfix: change column name and type to json (#14093)#14115
mattlord merged 3 commits intorelease-15.0from
backport-14093-to-release-15.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 28, 2023

Description

This is a backport of #14093

@vitess-bot @shlomi-noach
bugfix: change column name and type to json (#14093)
a0f7bae 
Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication labels Sep 28, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 28, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added Type: Bug NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 28, 2023
@github-actions github-actions bot added this to the v15.0.5 milestone Sep 28, 2023
@mattlord mattlord removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 28, 2023
mattlord and others added 2 commits September 28, 2023 12:02
@mattlord
Adjust new unit test for v15
84c66f2 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@frouioui
Merge remote-tracking branch 'origin/release-15.0' into backport-1409…
f669f4b 
…3-to-release-15.0

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@mattlord mattlord merged commit 87fb7e9 into release-15.0 Sep 29, 2023
@mattlord mattlord deleted the backport-14093-to-release-15.0 branch September 29, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattlord mattlord mattlord approved these changes

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: VReplication Type: Bug

Projects

None yet

Milestone

v15.0.5

Development

Successfully merging this pull request may close these issues.

3 participants

@mattlord @shlomi-noach @frouioui