Skip to content

[release-17.0] Enable failures in tools/e2e_test_race.sh and fix races (#13654)#14011

Merged
frouioui merged 2 commits intorelease-17.0from
backport-13654-to-release-17.0
Sep 19, 2023
Merged

[release-17.0] Enable failures in tools/e2e_test_race.sh and fix races (#13654)#14011
frouioui merged 2 commits intorelease-17.0from
backport-13654-to-release-17.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Sep 18, 2023 •
edited by frouioui
Loading

Description

This is a backport of #13654

Edit: this also backport #13045

@vitess-bot
Enable failures in tools/e2e_test_race.sh and fix races (#13654)
7fd46f3 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot added the Backport This is a backport label Sep 18, 2023
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner September 18, 2023 13:45
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Sep 18, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 18, 2023
@github-actions github-actions bot added this to the v17.0.3 milestone Sep 18, 2023
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 18, 2023
@brendar @austenLacy
@rohit-nayak-ps @frouioui
Vttablet schema tracking: Fix _vt.schema_version corruption (#13045)
2c8a78b 
* Copy fields from schema.Engine before modifying

This fixes a race condition which caused protobuf marshaled schema
data in _vt.schema_version rows to become corrupted when ColumnType was
modified between the time when Field message sizes were calculated
and when Field message data was written to the buffer.

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>

* Acquire schema engine mutex while marshaling schema

This change is purely defensive, but it may help avoid future
race conditions caused by modifying shared schema structs while
they are being marshaled to protobuf.

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>

* reorganize imports and allocate slices with make

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

* gofmt

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

* flakey unit test

Signed-off-by: Austen Lacy <austen.lacy@shopify.com>

* Use common code to update column_type for both vstreamer and rowstream events in a thread-safe fashion. Fix related tests

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Use DBName and not keyspace name while getting extended field info!

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix TestVStreamSharded

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
Signed-off-by: Austen Lacy <austen.lacy@shopify.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Austen Lacy <austen.lacy@shopify.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui merged commit 4d13c34 into release-17.0 Sep 19, 2023
@frouioui frouioui deleted the backport-13654-to-release-17.0 branch September 19, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@deepthi deepthi Awaiting requested review from deepthi

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

Assignees

No one assigned

Labels

Backport This is a backport Component: Build/CI Type: Bug

Projects

None yet

Milestone

v17.0.3

Development

Successfully merging this pull request may close these issues.

3 participants

@frouioui @rohit-nayak-ps @brendar