Skip to content

Add support for new lock syntax in MySQL8#13965

Merged
harshit-gangal merged 3 commits intovitessio:mainfrom
github:arthur/mysql8-lock-syntax
Nov 16, 2023
Merged

Add support for new lock syntax in MySQL8#13965
harshit-gangal merged 3 commits intovitessio:mainfrom
github:arthur/mysql8-lock-syntax

Conversation

@arthurschreiber
Copy link
Member

@arthurschreiber arthurschreiber commented Sep 13, 2023

Description

This completes the work to enable the following syntax in vitess:

  • SELECT .. FOR SHARE (NOWAIT|SKIP LOCKED)
  • SELECT .. FOR UPDATE (NOWAIT|SKIP LOCKED)

The aim is to finish the work started in #5336, which added the keywords to the syntax but didn't modify the ast and other functions to handle it.

Original author: @patrickcarnahan

Related Issue(s)

Fixes #5249

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@patrickcarnahan @arthurschreiber
add new lock syntax for mysql8
12df838 
Signed-off-by: Patrick Carnahan <patrickcarnahan@github.com>
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 13, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 13, 2023
@github-actions github-actions bot added this to the v18.0.0 milestone Sep 13, 2023
@arthurschreiber arthurschreiber added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 13, 2023
GuptaManan100
GuptaManan100 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

harshit-gangal
harshit-gangal reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plan test should be added for these locks

@frouioui frouioui modified the milestones: v18.0.0, v19.0.0 Sep 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Oct 30, 2023
@arthurschreiber arthurschreiber removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Oct 30, 2023
@frouioui
Copy link
Member

frouioui commented Nov 13, 2023

Hey @arthurschreiber are you still working on this?

@arthurschreiber
Copy link
Member Author

arthurschreiber commented Nov 13, 2023

Yes, just didn't have time to add the missing tests. 😖

@frouioui
Copy link
Member

frouioui commented Nov 13, 2023

Yes, just didn't have time to add the missing tests. 😖

No worries! I was just wondering the state of this PR 🚀

harshit-gangal and others added 2 commits November 16, 2023 12:19
@harshit-gangal @arthurschreiber
added plan test
b71da5e 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@arthurschreiber
Merge branch 'main' of https://github.com/vitessio/vitess into arthur…
82ab584 
…/mysql8-lock-syntax
@harshit-gangal harshit-gangal merged commit 29a9bf4 into vitessio:main Nov 16, 2023
@BrandonSurowiec BrandonSurowiec mentioned this pull request Nov 16, 2023
Merged
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@arthurschreiber @patrickcarnahan
@harshit-gangal @ejortegau
Add support for new lock syntax in MySQL8 (vitessio#13965)
cf5f274 
Signed-off-by: Patrick Carnahan <patrickcarnahan@github.com>
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Patrick Carnahan <patrickcarnahan@github.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>
@crynobone crynobone mentioned this pull request Jan 3, 2024
Merged
@github-actions github-actions bot mentioned this pull request Feb 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui frouioui approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

+1 more reviewer

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Milestone

v19.0.0

Development

Successfully merging this pull request may close these issues.

Add support for SKIP LOCKED and NOWAIT

5 participants

@arthurschreiber @frouioui @harshit-gangal @GuptaManan100 @patrickcarnahan