Skip to content

[release-16.0] Upgrade the Golang version to go1.20.8#13932

Merged
frouioui merged 3 commits intorelease-16.0from
upgrade-go-to-1.20.8-on-release-16.0
Sep 8, 2023
Merged

[release-16.0] Upgrade the Golang version to go1.20.8#13932
frouioui merged 3 commits intorelease-16.0from
upgrade-go-to-1.20.8-on-release-16.0

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Sep 7, 2023 •
edited by frouioui
Loading

This Pull Request bumps the Golang version to go1.20.8 and the bootstrap version to 14.6.

Do not trust the bot blindly. A thorough code review must be done to ensure all the files have been correctly modified.

There are a few manual steps remaining:

  • Make sure you update the Golang version used in the previous and next release branches for the Upgrade/Downgrade tests.
  • Build and Push the bootstrap images to Docker Hub, the bot cannot handle that.
  • Update the ./.github/workflows/*.yml files with the newer Golang version, the bot cannot handle that due to permissions.
    • To accomplish this, run the following: go run ./go/tools/go-upgrade/go-upgrade.go upgrade workflows --go-to=1.20.8

@frouioui
bump go version to go1.20.8
552240a 
Signed-off-by: GitHub <noreply@github.com>
@github-actions github-actions bot added the Benchmark me Add label to PR to run benchmarks label Sep 7, 2023
@github-actions github-actions bot requested a review from deepthi as a code owner September 7, 2023 00:20
@github-actions github-actions bot added the Component: General Changes throughout the code base label Sep 7, 2023
@github-actions github-actions bot requested a review from mattlord as a code owner September 7, 2023 00:20
@github-actions github-actions bot added go Skip CI Skip CI actions from running labels Sep 7, 2023
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Sep 7, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 7, 2023
@frouioui frouioui mentioned this pull request Sep 7, 2023
Closed
3 tasks
@frouioui
Merge remote-tracking branch 'origin/release-16.0' into upgrade-go-to…
5205ea7 
…-1.20.8-on-release-16.0

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Sep 7, 2023
@frouioui frouioui mentioned this pull request Sep 7, 2023
Merged
@frouioui frouioui removed the Skip CI Skip CI actions from running label Sep 7, 2023
@frouioui
Bump workflows to go1.20.8
7f498aa 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the upgrade-go-to-1.20.8-on-release-16.0 branch from 4c96d22 to 7f498aa Compare September 7, 2023 21:47
@frouioui frouioui added this to the v16.0.5 milestone Sep 7, 2023
deepthi
deepthi approved these changes Sep 8, 2023
View reviewed changes
build.env

go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.5 || echo "Go version reported: `go version`. Version 1.20.5+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."
goversion_min 1.20.8 || echo "Go version reported: `go version`. Version 1.20.8+ recommended. See https://vitess.io/contributing/build-from-source for install instructions."
Copy link
Copy Markdown
Collaborator

@deepthi deepthi Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here as on #13934 about enforcing major version versus minor version.

Copy link
Copy Markdown
Collaborator

@deepthi deepthi Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is just recommended. 👍

@frouioui frouioui merged commit 1fd96b4 into release-16.0 Sep 8, 2023
@frouioui frouioui deleted the upgrade-go-to-1.20.8-on-release-16.0 branch September 8, 2023 17:48
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@dkhenry dkhenry Awaiting requested review from dkhenry

+1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Benchmark me Add label to PR to run benchmarks Component: General Changes throughout the code base go Type: CI/Build

Projects

None yet

Milestone

v16.0.5

Development

Successfully merging this pull request may close these issues.

2 participants

@deepthi @frouioui