Properly treat general tablespace names as case sensitive

[mattlord]

Description

MySQL General Tablespace names are case sensitive: https://dev.mysql.com/doc/refman/8.0/en/general-tablespaces.html

In the Vitess parser, however, we were treating them as case-insensitive. This could lead to query failures handling SQL statements containing a TABLESPACE clause in any path where we call SetUpperCase(true) on a sqlparser.TrackedBuffer such as indirectly anywhere that calls sqlparser.CanonicalString().

Note
PARTITION clauses can contain their own independent TABLESPACE definition and in that case it IS handled properly today via astPrintf formatting here:

vitess/go/vt/sqlparser/ast_format.go

Lines 487 to 489 in 99271d4

	if node.TableSpace != "" {
	buf.astPrintf(node, " tablespace %#s", node.TableSpace)
	}

The newly added unit test case fails on main:

go test -timeout 30s -run ^TestCanonicalOutput$ vitess.io/vitess/go/vt/sqlparser

--- FAIL: TestCanonicalOutput (0.00s)
    --- FAIL: TestCanonicalOutput/create_table_a_(v_varchar(32))_engine=InnoDB_tablespace=innodb_system (0.00s)
        /Users/matt/git/vitess/go/vt/sqlparser/tracked_buffer_test.go:287: 
            	Error Trace:	/Users/matt/git/vitess/go/vt/sqlparser/tracked_buffer_test.go:287
            	Error:      	Not equal: 
            	            	expected: "CREATE TABLE `a` (\n\t`v` varchar(32)\n) ENGINE InnoDB,\n  TABLESPACE innodb_system"
            	            	actual  : "CREATE TABLE `a` (\n\t`v` varchar(32)\n) ENGINE InnoDB,\n  TABLESPACE INNODB_SYSTEM"
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -3,2 +3,2 @@
            	            	 ) ENGINE InnoDB,
            	            	-  TABLESPACE innodb_system
            	            	+  TABLESPACE INNODB_SYSTEM
            	Test:       	TestCanonicalOutput/create_table_a_(v_varchar(32))_engine=InnoDB_tablespace=innodb_system
            	Messages:   	bad serialization
FAIL
FAIL	vitess.io/vitess/go/vt/sqlparser	0.449s
FAIL

Related Issue(s)

• Fixes: Bug Report: General Tablespace Names Are Not Treated As Case Sensitive #13887

Checklist

• "Backport to:" labels have been added if this change should be back-ported
• Tests were added
• Did the new or modified tests pass consistently locally and on the CI
• Documentation is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[shlomi-noach]

Made redundant by #13884