Skip to content

Move upgrade downgrade tests to GitHub larger runners#13843

Closed
frouioui wants to merge 3 commits intovitessio:mainfrom
planetscale:move-upgrade-downgrade-tests-to-runner
Closed

Move upgrade downgrade tests to GitHub larger runners#13843
frouioui wants to merge 3 commits intovitessio:mainfrom
planetscale:move-upgrade-downgrade-tests-to-runner

Conversation

@frouioui
Copy link
Member

@frouioui frouioui commented Aug 23, 2023

Description

This PR moves the upgrade/downgrade tests to GitHub Larger runners. The dedicated runner name is gh-runner-upgrade-downgrade-16cores-1 and has 16-cores. The machine can scale up to 100 times, supporting 100 concurrent workflows.

When comparing an upgrade downgrade test (Run Upgrade Downgrade Test - Query Serving (Schema)) ran on PR #13835 (https://github.com/vitessio/vitess/actions/runs/5956621188/job/16157782259?pr=13835) and the same workflow but ran with the larger runners (https://github.com/vitessio/vitess/actions/runs/5957296442/job/16159769723) we can see we saved about 50% of the time needed to run the workflow.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 23, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 23, 2023
@github-actions github-actions bot added this to the v18.0.0 milestone Aug 23, 2023
@frouioui frouioui changed the title ?ove upgrade downgrade tests to GitHub larger runners Move upgrade downgrade tests to GitHub larger runners Aug 23, 2023
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Aug 23, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui closed this Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants