Move upgrade downgrade tests to GitHub larger runners#13843
Closed
frouioui wants to merge 3 commits intovitessio:mainfrom
Closed
Move upgrade downgrade tests to GitHub larger runners#13843frouioui wants to merge 3 commits intovitessio:mainfrom
frouioui wants to merge 3 commits intovitessio:mainfrom
Conversation
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
rohit-nayak-ps
approved these changes
Aug 23, 2023
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the upgrade/downgrade tests to GitHub Larger runners. The dedicated runner name is
gh-runner-upgrade-downgrade-16cores-1and has 16-cores. The machine can scale up to 100 times, supporting 100 concurrent workflows.When comparing an upgrade downgrade test (
Run Upgrade Downgrade Test - Query Serving (Schema)) ran on PR #13835 (https://github.com/vitessio/vitess/actions/runs/5956621188/job/16157782259?pr=13835) and the same workflow but ran with the larger runners (https://github.com/vitessio/vitess/actions/runs/5957296442/job/16159769723) we can see we saved about 50% of the time needed to run the workflow.Related Issue(s)
Checklist
Deployment Notes