planbuilder: Fix infinite recursion for subqueries#13783
Merged
dbussink merged 1 commit intovitessio:release-16.0from Aug 14, 2023
Merged
planbuilder: Fix infinite recursion for subqueries#13783dbussink merged 1 commit intovitessio:release-16.0from
dbussink merged 1 commit intovitessio:release-16.0from
Conversation
The rewriting on v16 didn't consider the case where we already had an extract subquery. In that case we don't extract again, to avoid infinite recursion. This does not affect v17 and later as this was fixed in the refactor in vitessio#12197. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
systay
approved these changes
Aug 14, 2023
harshit-gangal
approved these changes
Aug 14, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rewriting on v16 didn't consider the case where we already had an extract subquery. In that case we don't extract again, to avoid infinite recursion.
This does not affect v17 and later as this was fixed in the refactor in #12197.
Related Issue(s)
Fixes #13780
Checklist