Skip to content

Fix bug in fileNameFromPosition test helper #13778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frouioui merged 2 commits into from
Sep 19, 2023
Merged

Fix bug in fileNameFromPosition test helper #13778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ce88c1
Fix bug in `fileNameFromPosition` test helper
timvaillancourt Aug 13, 2023
a9cc3bc
Use pos string from real failure
timvaillancourt Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion go/test/endtoend/reparent/plannedreparent/reparent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"fmt"
"strconv"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -557,7 +558,16 @@ func waitForFilePosition(t *testing.T, clusterInstance *cluster.LocalProcessClus

// fileNameFromPosition gets the file name from the position
func fileNameFromPosition(pos string) string {
return pos[0 : len(pos)-4]
Copy link
Member

@mattlord mattlord Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this was assuming there were 3 position digits this whole time? 🙂

Copy link
Contributor Author

@timvaillancourt timvaillancourt Aug 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattlord yeah strange! 🙈

s := strings.SplitN(pos, ":", 2)
if len(s) != 2 {
return ""
}
return s[0]
}

func TestFileNameFromPosition(t *testing.T) {
Copy link
Contributor Author

@timvaillancourt timvaillancourt Aug 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is testing a test-helper, which may be overkill. Happy to remove this 👍

assert.Equal(t, "", fileNameFromPosition("shouldfail"))
assert.Equal(t, "FilePos/vt-0000000101-bin.000001", fileNameFromPosition("FilePos/vt-0000000101-bin.000001:123456789"))
}

// rowNumberFromPosition gets the row number from the position
Expand Down