Skip to content

[release-17.0] CI: fix onlineddl_scheduler flakiness (#13754)#13760

Merged
harshit-gangal merged 1 commit intorelease-17.0from
backport-13754-to-release-17.0
Aug 10, 2023
Merged

[release-17.0] CI: fix onlineddl_scheduler flakiness (#13754)#13760
harshit-gangal merged 1 commit intorelease-17.0from
backport-13754-to-release-17.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Aug 10, 2023

Description

This is a backport of #13754

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@vitess-bot vitess-bot bot added Backport This is a backport Component: Build/CI Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: CI/Build labels Aug 10, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Aug 10, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Aug 10, 2023
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Aug 10, 2023
@github-actions github-actions bot added this to the v17.0.2 milestone Aug 10, 2023
@shlomi-noach shlomi-noach added Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) and removed Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) labels Aug 10, 2023
@shlomi-noach shlomi-noach requested a review from a team August 10, 2023 07:26
@harshit-gangal harshit-gangal merged commit fd71824 into release-17.0 Aug 10, 2023
@harshit-gangal harshit-gangal deleted the backport-13754-to-release-17.0 branch August 10, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: Build/CI Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: CI/Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants