Manual cherry-pick of 13339#13733
Merged
deepthi merged 3 commits intovitessio:release-16.0from Aug 10, 2023
Merged
Conversation
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
added
Type: Bug
Backport
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
requested review from
GuptaManan100,
deepthi,
rsajwani and
shlomi-noach
as code owners
shlomi-noach
approved these changes
Aug 10, 2023
deepthi
approved these changes
Aug 10, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Manually recreated the changes from #13339 to 16.0, rather than doing a complex merge.
FIXME: the changes are currently not tested, because I am not sure where should we invoke
verifyRestorePositionAndTimeStats(). The test case inmainwhere I was doing this is not present inrelease-16.0Related Issue(s)
#13339
Checklist
Deployment Notes